Add scrollbar to popup window in OS Commerce

Do you have a question? Post it now! No Registration Necessary.  Now with pictures!

Threaded View
I'm running OS Commerce and I've pasted the script below that is used
to "popup" an enlarged image when a user clicks on the image. I need to
add a scrollbar to the popup but don't know how to.

Can anyone help?

  $Id: popup_image.php,v 1.18 2003/06/05 23:26:23 hpdl Exp $

  osCommerce, Open Source E-Commerce Solutions

  Copyright (c) 2003 osCommerce

  Changes    : Minor enahncement provides proper popup window resizing
based on image, also adds a close window [x] option.

  Released under the GNU General Public License


  $products_query = tep_db_query("select pd.products_name,
p.products_image from " . TABLE_PRODUCTS . " p left join " .
TABLE_PRODUCTS_DESCRIPTION . " pd on p.products_id = pd.products_id
where p.products_status = '1' and p.products_id = '" .
(int)$HTTP_GET_VARS['pID'] . "' and pd.language_id = '" .
(int)$languages_id . "'");
  $products = tep_db_fetch_array($products_query);
<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">
<html <?php echo HTML_PARAMS; ?>>
<meta http-equiv="Content-Type" content="text/html; charset=<?php echo
<title><?php echo $products['products_name']; ?></title>
<link type="text/css" rel="stylesheet" href="/css/stylesheet.css">
<base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER :
<script language="javascript"><!--
var i=0;
function resize() {
  if (navigator.appName == 'Netscape') i=40;
  if (document.images[0]) window.resizeTo(document.images[0].width +40,
<body onLoad="resize();">
<p class="smallText" align="center">
<?php echo tep_image(DIR_WS_IMAGES . $products['products_image'],
$products['products_name']); ?>
<a href="javascript:window.close()"><br><u>Close Window</u>
<?php require('includes/application_bottom.php'); ?>

Re: Add scrollbar to popup window in OS Commerce


Quoted text here. Click to load it

You've pasted the code of the pop-up. Allowing scrollbars (or actually  
forbidding scrollbars) is done by javascript on the opening page itself.  
Look for a

Rik Wasmus
* I'm testing several new newsreaders at the moment. Please excuse  
possible errors and weird content. *

Re: Add scrollbar to popup window in OS Commerce

Schoolie wrote :
Quoted text here. Click to load it

Several parts of doctype declaration must NOT be lowercase:

Common Validation Problems:
Using all lowercase letters in a DOCTYPE

Recommended DTDs to use in your Web document.

Also, using a strict DTD for new webpages makes more sense.

Quoted text here. Click to load it

If this isn't going to be a frame within a frameset, then defining a
<base> is not making sense.

Quoted text here. Click to load it

language is deprecated while type is both backward and forward-compatible.
So here,

<script type="text/javascript">

is perfect

Quoted text here. Click to load it

Relying on userAgent string detection is often unreliable, difficult to
manage and wrong. Here, your detection does not even try to detect more
popular browser like Firefox, Mozilla, Seamonkey (Gecko-family) and
others like Safari.

Using Web Standards in your Web Pages
4 Developing Cross Browser/Cross Platform Pages
  4.1 Browser identification approach (aka "browser sniffing"): not
best, not reliable approach
  4.2 Using Object/Feature support detection approach: best and overall
most reliable


A Strategy That Works: Object/Feature Detecting by comp.lang.javascript
newsgroup FAQ notes

Browser detection - No; Object detection - Yes by Peter-Paul Koch

Quoted text here. Click to load it

The window already has focus; it's useless and unneeded to set its focus
again. The focus() command has been abused before and many Gecko-based
users turn such js-command off in their user preferences setting.

Quoted text here. Click to load it

Everything you need is described in

Quoted text here. Click to load it

Please do not create a javascript link to close the window: it's
useless, bad javascript usage, wrong, etc.

4.24 I have <a href="javascript:somefunction()"> ... ?

Top Ten Web-Design Mistakes of 2002
6. JavaScript in Links

HTML Techniques for Web Content Accessibility Guidelines 1.0
Avoid creating links that use "javascript" as the URI. If a user is not
using scripts, then they won't be able to link since the browser can't
create the link content.

See also section 7.2.1
Never use this form of code for links:
<a href="" ...>

Alternatively, you can try

Open a sub-window and dynamically DOM-insert an image

Opening enlarged images of different sizes into a single window

Using Web Standards in your Web Pages (Updated Dec. 2006)

Site Timeline